One vector for regexes and matchers#133
Draft
IhateTrains wants to merge 11 commits intoParadoxGameConverters:masterfrom
Draft
One vector for regexes and matchers#133IhateTrains wants to merge 11 commits intoParadoxGameConverters:masterfrom
IhateTrains wants to merge 11 commits intoParadoxGameConverters:masterfrom
Conversation
Member
|
I like where you're gong with this, but I think the modern idiom is to use std::variant and std::visit instead of inheritance: https://www.bfilipek.com/2020/04/variant-virtual-polymorphism.html Can you put together another PR on a different branch using that method and see how feasible it is? And maybe split out the cleanup efforts to a new PR so we can just get things merged. |
Member
|
I'm not sure we should give up on this. I'd like more time to compare to how the std::variant version came out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
registeredRegexesAndMatchersvector